-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checksum validation to KCL packages #243
Conversation
Signed-off-by: Nishant Bansal <[email protected]>
Hey @zong-zhe, I want to write a test for the Go tool I developed that includes a checksum. I plan to first push a test package to a local registry using Docker and then validate my code by updating the |
Signed-off-by: Nishant Bansal <[email protected]>
This PR is ready for review. Feedback and suggestions for improvement are appreciated. |
Through this code, a new manifest (with a checksum field) and old blobs (config, layers) will be generated and tagged with the corresponding version of the KCL package. However, the old manifest will remain in the registry as a dangling manifest without a tag. |
Fixed kcl-lang#243 Signed-off-by: Emin Aktas <[email protected]>
Signed-off-by: Nishant Bansal <[email protected]>
cc @zong-zhe |
cc @zong-zhe |
Signed-off-by: Nishant Bansal <[email protected]>
7ca38d2
to
df27119
Compare
@zong-zhe PTAL |
Hey @zong-zhe |
cc @zong-zhe |
Signed-off-by: Nishant Bansal <[email protected]>
Any comments on this? Please let me know as the deadlines are approaching quickly. |
Signed-off-by: Nishant Bansal <[email protected]>
Done, ptal |
Signed-off-by: Nishant Bansal <[email protected]>
Also could you please clarify this? |
😄 I will update it later in this PR kcl-lang/kpm#520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Please confirm that you have read the document before PR submitted
2. Contact Information(Optional)
If it is convenient, please provide your contact information so we can reach you when processing the PR: